History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: OX-137
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: AJ Tarachanowicz
Reporter: AJ Tarachanowicz
Votes: 0
Watchers: 0

If you were logged in you would be able to see more operations.
OpenX Ad Server

Installation / Database settings - Add local socket connection option

Created: 04/Dec/07 01:10 PM   Updated: 22/Apr/08 10:04 AM
Component/s: OXP: Database Abstraction: MySQL
Affects Version/s: None
Fix Version/s: Milestone 18, OpenX 2.5.67-beta, OXP 2.7.5-dev
Security Level: Public (All users can see these issues)

Time Tracking:
Original Estimate: 1h
Original Estimate - 1h
Remaining Estimate: 0h
Time Spent - 11.03h
Time Spent: 11.03h
Time Spent - 11.03h

 Description  « Hide
Original ticket @ https://developer.openads.org/ticket/1018

Openads 2.5 supports connecting to databases using sockets, but there is no UI setting, nor the installer allows the user to select a socket connection. Using sockets is a very common setup because it gives a speed increase over TPC/IP.

Adding a checkbox "Use local socket connection" and a text field to supply the socket path is required.

On MySQL socket connections are always used when the hostname is "localhost", so the setting is only useful in some special cases when users need to supply a named socket.

On the contrary PostgreSQL is always using TCP/IP if an hostname is supplied. Some research will be needed to know if named sockets are supported, otherwise we need to disable the socket name input field when the checkbox is checked.

 All   Comments   Work Log   Change History   FishEye   Crucible   Builds      Sort Order: Ascending order - Click to sort in descending order
Chris Nutting - 04/Jan/08 05:16 PM
I've merged this into trunk (locally) and resolved the issues with changes to settings/preference, however it doesn't seem to be working for me.

It seems that the socket value isn't being saved to the config file, this is because the $aDatabase details are passed through this function: https://developer.openads.org/browser/trunk/lib/OA/Upgrade/Configuration.php#L239 before being written to the conf file, this means that any unrecognised entries are ignored.

There is also the question of if the "Database port" should be disabled when you select socket connection (port is only relevant with TCP connections...), and this field is required not-empty (possibly integer?) by the client-side JavaScript on the installer page.

In addition, although the installer now has the database socket option, the settings->database settings screen doesn't allow you to change/choose local socket.

AJ Tarachanowicz - 17/Jan/08 04:21 AM
Ready for review and merge

AJ Tarachanowicz - 17/Jan/08 04:23 AM
Chris when you merge this down could you pelase set the proper fixed version. Thanks

Chris Nutting - 28/Jan/08 06:02 PM
Moving to next milestone since it is not required for this milestone