History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: OX-1432
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Lukasz Wikierski
Reporter: Arlen Coupland
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
OpenX Ad Server

Banner-edit page does not display error messages

Created: 29/Feb/08 10:06 AM   Updated: 15/Jul/08 02:59 PM
Component/s: OXP: User Interface
Affects Version/s: OpenX 2.4.4
Fix Version/s: OpenX 2.4.8, Milestone 21
Security Level: Public (All users can see these issues)

Time Tracking:
Original Estimate: Not Specified
Remaining Estimate: 0h
Time Spent - 0.58h
Time Spent: 0.58h
Time Spent - 0.58h


 Description  « Hide
When uploading banners, users have reported that the banner-edit page returns to them with an 'Error' at the top but no description inside.

Inside banner-edit.php, it seems that the variables used for error messages are not declared:
Changing:
$strErrorUploadBasedir
to:
$GLOBALS['strErrorUploadBasedir']

resulted in an actual error message being displayed.



 All   Comments   Work Log   Change History   FishEye   Crucible   Builds      Sort Order: Ascending order - Click to sort in descending order
Matteo Beccati - 29/Feb/08 02:15 PM
It's most probably lib-swf.inc.php dealing with a non-compatible SWF banner and exiting with "Error". Future work is planned to rewrite the SWF handling functionality, but it would probably be nice to have the function fall to fail according to the application standards.

Also, it would be great if people could send over those SWF files for us to test them with the new Flash decompiler.


Arlen Coupland - 29/Feb/08 02:19 PM - edited
Matteo, thanks for the comment. That will help in finding why certain users have an error in the first place.

For this ticket, however, users are having no Error Message Description no matter what the error is – so we can not help debug them because the only clue they have is 'Error' rather than 'Error - Could not access uploaded file, probably due to safemode or open_basedir restrictions'


Pawel Dachterski - 31/Mar/08 12:30 PM
Probably the same issue for:
  • $strErrorUploadUnknown
  • $strErrorUploadSecurity

Arlen Coupland - 29/May/08 10:52 AM
I'm upping priority from Minor to Major as this ticket makes it impossible to debug any banner upload issues

Sue Houghton - 15/Jul/08 02:59 PM
Haven't been able to reproduce this issue, but spoken to Arlen and he is happy with the fix. Closing ticket.