History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: OX-3311
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Lukasz Wikierski
Reporter: andrzej.swedrzynski
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
OpenX Ad Server

Audit logging missing from new campaign/zone linking page

Created: 18/Jun/08 10:14 AM   Updated: 22/Apr/09 08:07 AM
Component/s: None
Affects Version/s: None
Fix Version/s: Milestone 23, OpenX 2.7.22-dev
Security Level: Public (All users can see these issues)

Time Tracking:
Original Estimate: 6h
Original Estimate - 6h
Remaining Estimate: 2.92h
Time Spent - 3.08h Remaining Estimate - 2.92h
Time Spent: 3.08h
Time Spent - 3.08h Remaining Estimate - 2.92h

Issue Links:
Reference
 


 Description  « Hide
A new high-performance function which links zones to a campaign unfortunately uses raw SQL query, therefore is not logged into audit trail. We should look into how we can add audit-trail to this functionality. This is a follow-up work for OX-2890.

 All   Comments   Work Log   Change History   FishEye   Crucible   Builds      Sort Order: Ascending order - Click to sort in descending order
Change by andrzej.swedrzynski - 18/Jun/08 10:15 AM
Field Original Value New Value
Link This issue references OX-2890 [ OX-2890 ]

Lukasz Wikierski - 19/Jun/08 08:19 AM - edited
When changing methods linking zones to a campaign, don't forget about Oracle limitation ORA-01795: maximum number of expressions in a list is 1000

At first look there are 2 ways of adding audit log:

  1. we can use current query to get list of banner-zones to link (avoid checking if it is possible to link banner<->zone in PHP). Then in loop add all links by DB_Objects
    • pros: no changes in audit log, this should be faster than methods in Admin_DA
    • cons: could be slow (eg. 10 banner in campaign and 1000 zones gives 10000 inserts by DB_Objects)
  2. leave this query as is, but add new auditlog entry (eg Mass Ad Zone Association) with parameters list of zones and list of banners, or list of pairs banner-zone (more data but more accurate)
    • pros: we stay with current efficiency
    • cons: in future we'll not able to search Mass Ad Zone Association for given banner in auditlog (or it will be costly operation - unserialize all parameters from all "Mass Ad Zone Association" logs)

Change by andrew.hill - 20/Jun/08 08:51 AM
Workflow OX Workflow [ 25153 ] Code Project Workflow [ 25572 ]

Change by andrew.hill - 20/Jun/08 09:32 AM
Workflow Code Project Workflow [ 25572 ] Copy of Code Project Workflow [ 29251 ]

Change by andrew.hill - 20/Jun/08 09:39 AM
Workflow Copy of Code Project Workflow [ 29251 ] Code Project Workflow [ 32442 ]

Lukasz Wikierski - 18/Sep/08 08:41 AM
Time Worked: 1.33h
chat with Andrew (way of fixing)
prepare test cases, debugging
start fixing
Change by andrew.hill - 18/Sep/08 11:36 AM
Status Needs Verification [ 10000 ] Verified [ 10001 ]

Change by andrew.hill - 18/Sep/08 11:36 AM
Status Verified [ 10001 ] Open [ 1 ]


Change by andrew.hill - 18/Sep/08 11:37 AM
Original Estimate 6h [ 21600 ]
Remaining Estimate 6h [ 21600 ]
Fix Version/s OpenX 2.7.22-dev [ 10440 ]
Fix Version/s Milestone 23 [ 10386 ]
Fix Version/s Next Milestone [ 10060 ]


Change by andrew.hill - 18/Sep/08 11:40 AM
Summary Add audit logging to new, high-performance zone linking routine Audit logging missing from new campaign/zone linking page
Issue Type Task [ 3 ] Bug [ 1 ]

Change by Lukasz Wikierski - 18/Sep/08 01:19 PM
Status Open [ 1 ] In Progress [ 3 ]

Change by Lukasz Wikierski - 19/Sep/08 08:41 AM
Remaining Estimate 6h [ 21600 ] 4.67h [ 16800 ]
Time Spent 1.33h [ 4800 ]

Lukasz Wikierski - 19/Sep/08 08:42 AM
Time Worked: 1.75h
fixing
testing
Change by Lukasz Wikierski - 19/Sep/08 08:42 AM
Remaining Estimate 4.67h [ 16800 ] 2.92h [ 10500 ]
Time Spent 1.33h [ 4800 ] 3.08h [ 11100 ]

Lukasz Wikierski - 19/Sep/08 08:49 AM
Fixed:
  • DB_DataObjects used to insert and delete associations, so audit logs are done automatically

Checked the logic in linking zones/banners/campaigns pages. Found one error OX-4092 on zone-include.php (zone linking to campaigns/ banners) page


Change by Lukasz Wikierski - 19/Sep/08 08:49 AM
Status In Progress [ 3 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]

Sue Houghton - 23/Sep/08 04:11 PM
closed in 2.7.23-beta

Change by Sue Houghton - 23/Sep/08 04:11 PM
Status Resolved [ 5 ] Closed [ 6 ]

Change by andrzej.swedrzynski - 22/Apr/09 08:07 AM
Link This issue is referenced by OX-5260 [ OX-5260 ]