History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: OX-3554
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Chris Nutting
Reporter: Tobias Schwarz
Votes: 0
Watchers: 0

If you were logged in you would be able to see more operations.
OpenX Ad Server

XML-RPC SPC Output-Format

Created: 11/Jul/08 11:28 AM   Updated: 23/Sep/08 04:45 PM
Component/s: None
Affects Version/s: OpenX 2.5.70-beta
Fix Version/s: Milestone 21, OpenX 2.6.1, OpenX 2.7.10-dev
Security Level: Public (All users can see these issues)

Time Tracking:
Original Estimate: 0.17h
Original Estimate - 0.17h
Remaining Estimate: 0h
Time Spent - 0.58h
Time Spent: 0.58h
Time Spent - 0.58h

 Description  « Hide
The output format of the XML-RPC SPC is different compared to the output of a normal XML-RPC call. Informations about the banner are not included, only the html is printed.
Index: lib/max/Delivery/XML-RPC.php
--- lib/max/Delivery/XML-RPC.php        (revision 22544)
+++ lib/max/Delivery/XML-RPC.php        (working copy)
@@ -449,7 +449,7 @@
         // Get the banner
         $output = MAX_adSelect('zone:'.$zoneid, '', $target, $source, $withtext, '', $context, $richmedia, $ct0, $GLOBALS['loc'], $GLOBALS['referer']);
-        $spc_output[$varname] = $output['html'];
+        $spc_output[$varname] = $output;
         // Block this banner for next invocation
         if (!empty($block) && !empty($output['bannerid'])) {

the same change has to be made in the compiled delivery engine...

~~ line 4410

 All   Comments   Work Log   Change History   FishEye   Crucible   Builds      Sort Order: Ascending order - Click to sort in descending order
Chris Nutting - 18/Jul/08 10:04 AM
Fixed in //trunk, but awaiting 2.6/trunk unfreeze before closing

This changeset: https://developer.openx.org/fisheye/changelog/Public?cs=22852 needs to be merged down to 2.6/trunk

Sue Houghton - 11/Aug/08 11:25 AM
Passed retest in 2.6.1-rc2