History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: OX-3634
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Critical Critical
Assignee: andrew.hill
Reporter: Monique Szpak
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
OpenX Ad Server

No validation rules on the table prefix

Created: 28/Jul/08 09:43 AM   Updated: 17/Feb/09 03:34 PM
Component/s: OXP: Installation & Upgrade System
Affects Version/s: OpenX 2.4.8, Milestone 21, OpenX 2.6.0, OpenX 2.7.10-dev, OpenX 2.7.14-dev, OpenX 2.7.27-beta
Fix Version/s: Milestone 24, OpenX 2.6.3, OpenX 2.7.27-beta, OpenX 2.4.11
Security Level: Public (All users can see these issues)

Time Tracking:
Original Estimate: 4h
Original Estimate - 4h
Remaining Estimate: 0h
Time Spent - 5.33h
Time Spent: 5.33h
Time Spent - 5.33h

File Attachments: 1. Text File badchars_mysql.txt (3 kb)
2. Text File badchars_pgsql.txt (3 kb)

Image Attachments:

1. pgsql_263rc8.jpg
(107 kb)

2. pgsql_263rc8_2.jpg
(99 kb)

3. pgsql_error_message.jpg
(111 kb)
Issue Links:
Depends
 
Reference

Passed QA Version/s: OpenX 2.6.3


 Description  « Hide
The table prefix is not validated for illegal characters, or for characters that require quoting, in the installer.

Even valid characters that require quoting (such as hyphen) will cause errors throught the application due to inconsistant schema object identifier quoting.

Options:

1) disallow any character that requires quoting along with illegal characters using validation rules
2) disallow illegal characters only and fix the inconsistant schema object identifier quoting in the application.



 All   Comments   Work Log   Change History   FishEye   Crucible   Builds      Sort Order: Ascending order - Click to sort in descending order
Change by Pawel Dachterski - 30/Jul/08 08:14 AM
Field Original Value New Value
Status Needs Verification [ 10000 ] Verified [ 10001 ]

Change by andrew.hill - 04/Aug/08 03:27 PM
Status Verified [ 10001 ] Open [ 1 ]

Change by andrew.hill - 04/Aug/08 03:28 PM
Assignee Andrew Hill [ andrew.hill ] Lukasz Wikierski [ lukasz.wikierski ]
Fix Version/s OpenX 2.6.1 [ 10299 ]
Fix Version/s OpenX 2.7.13-dev [ 10371 ]
Fix Version/s Milestone 22 [ 10285 ]
Fix Version/s Next Milestone [ 10060 ]

Change by andrew.hill - 04/Aug/08 03:30 PM
Original Estimate 4h [ 14400 ]
Remaining Estimate 4h [ 14400 ]

Change by andrew.hill - 06/Aug/08 11:09 AM
Assignee Lukasz Wikierski [ lukasz.wikierski ] Bernard Lange [ bernard.lange ]

Change by Matteo Beccati - 06/Aug/08 12:33 PM
Description The table prefix is not validated for illegal characters, or for characters that require quoting, in the installer.

Even valid characters that require quoting (such as hyphen) will cause errors throught the application due to inconsistant schema object identifier quoting.

Options:

1) disallow any character that requires quoting along with illegal characters using validation rules
2) disallow illegal characters only and fix the inconsistant schema object identifier quoting in the application.
The table prefix is not validated for illegal characters, or for characters that require quoting, in the installer.

Even valid characters that require quoting (such as hyphen) will cause errors throught the application due to inconsistant schema object identifier quoting.

Options:

1) disallow any character that requires quoting along with illegal characters using validation rules
-2) disallow illegal characters only and fix the inconsistant schema object identifier quoting in the application.-

Change by andrew.hill - 13/Aug/08 07:41 AM
Fix Version/s OpenX 2.7.14-dev [ 10400 ]
Fix Version/s OpenX 2.7.13-dev [ 10371 ]

Change by andrew.hill - 22/Aug/08 12:51 PM
Status Open [ 1 ] Verified [ 10001 ]

Change by andrew.hill - 22/Aug/08 12:51 PM
Fix Version/s Milestone 22 [ 10285 ]
Fix Version/s OpenX 2.6.1 [ 10299 ]
Fix Version/s OpenX 2.7.14-dev [ 10400 ]

Change by andrew.hill - 29/Aug/08 03:04 PM
Status Verified [ 10001 ] Open [ 1 ]

Change by andrew.hill - 29/Aug/08 03:04 PM
Fix Version/s OpenX 2.6.2 [ 10364 ]
Fix Version/s OpenX 2.7.15-dev [ 10410 ]
Fix Version/s Milestone 23 [ 10386 ]

Change by Pawel Dachterski - 01/Sep/08 08:12 AM
Affects Version/s OpenX 2.7.14-dev [ 10400 ]

Change by andrew.hill - 02/Sep/08 03:56 PM
Fix Version/s OpenX 2.7.16-dev [ 10416 ]
Fix Version/s OpenX 2.7.15-dev [ 10410 ]

Change by bernard.lange - 04/Sep/08 08:56 AM
Remaining Estimate 4h [ 14400 ] 2h [ 7200 ]
Time Spent 2h [ 7200 ]

Change by bernard.lange - 04/Sep/08 08:57 AM
Remaining Estimate 2h [ 7200 ] 0.08h [ 300 ]
Time Spent 2h [ 7200 ] 3.92h [ 14100 ]

Change by bernard.lange - 04/Sep/08 09:39 AM
Remaining Estimate 0.08h [ 300 ] 0h [ 0 ]
Time Spent 3.92h [ 14100 ] 4.58h [ 16500 ]

Change by bernard.lange - 04/Sep/08 09:40 AM
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s OpenX 2.4.9 [ 10360 ]
Resolution Fixed [ 1 ]

Change by Sue Houghton - 25/Sep/08 03:09 PM
QA Notes N/A for 2.7-beta hosted release

Change by Sue Houghton - 06/Oct/08 09:17 AM
Fix Version/s OpenX 2.6.3 [ 10485 ]
Fix Version/s OpenX 2.6.2 [ 10364 ]

Change by Sue Houghton - 06/Oct/08 09:24 AM
Fix Version/s OpenX 2.4.10 [ 10484 ]
Fix Version/s OpenX 2.4.9 [ 10360 ]

Change by Sue Houghton - 14/Oct/08 01:35 PM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]
Assignee Bernard Lange [ bernard.lange ] Monique Szpak [ monique.szpak ]

Change by Sue Houghton - 14/Oct/08 02:32 PM
QA Notes N/A for 2.7-beta hosted release PGSQL still to be tested

Change by Monique Szpak - 21/Oct/08 02:17 PM
Attachment badchars_mysql.txt [ 11313 ]

Change by Monique Szpak - 21/Oct/08 02:18 PM
Attachment badchars_pgsql.txt [ 11314 ]

Change by Monique Szpak - 22/Oct/08 08:34 AM
Status Reopened [ 4 ] In Progress [ 3 ]

Change by Sue Houghton - 24/Oct/08 10:20 AM
Attachment pgsql_error_message.jpg [ 11332 ]

Change by Monique Szpak - 27/Oct/08 04:33 PM
Status In Progress [ 3 ] Resolved [ 5 ]
Fix Version/s  OpenX 2.7.27-beta [ 10487 ]
Fix Version/s Milestone 24 [ 10464 ]
Fix Version/s Milestone 23 [ 10386 ]
Fix Version/s OpenX 2.7.16-dev [ 10416 ]
Resolution Fixed [ 1 ]

Change by Sue Houghton - 27/Oct/08 05:31 PM
QA Notes PGSQL still to be tested resolved in 2.6.3-rc7

Change by Nataliya Drabyk - 29/Oct/08 11:14 AM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]

Change by Nataliya Drabyk - 29/Oct/08 11:14 AM
Attachment db_prefix.JPG [ 11350 ]

Change by Sue Houghton - 29/Oct/08 11:26 AM
Attachment pgsql_263rc8.jpg [ 11352 ]
Attachment pgsql_263rc8_2.jpg [ 11353 ]

Change by Monique Szpak - 29/Oct/08 12:33 PM
Link This issue references OX-4344 [ OX-4344 ]

Change by Nataliya Drabyk - 29/Oct/08 12:33 PM
Comment [ It is possible to create table prefix with non-Latin symbols (in current test case it was "ъъъъ_ " ) but but after installation was completed (BTW without an error) I've got pear error (see db_prefix.jpg attachment)
]

Change by Nataliya Drabyk - 29/Oct/08 12:35 PM
Attachment db_prefix.JPG [ 11350 ]

Change by Monique Szpak - 29/Oct/08 01:04 PM
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]

Change by Sue Houghton - 30/Oct/08 10:50 AM
QA Notes resolved in 2.6.3-rc7
Passed QA Version/s OpenX 2.6.3 [ 10485 ]

Change by Sue Houghton - 03/Nov/08 01:40 PM
Affects Version/s  OpenX 2.7.27-beta [ 10487 ]

Change by andrew.hill - 04/Nov/08 08:41 AM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]

Change by andrew.hill - 04/Nov/08 09:26 AM
Link This issue is depended on by OX-4282 [ OX-4282 ]

Change by Monique Szpak - 04/Nov/08 09:47 AM
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]

Change by Monique Szpak - 04/Nov/08 09:48 AM
Time Spent 4.58h [ 16500 ] 5.33h [ 19200 ]

Change by Sue Houghton - 11/Nov/08 10:48 AM
Status Resolved [ 5 ] Closed [ 6 ]

Change by andrew.hill - 28/Jan/09 05:36 PM
Resolution Fixed [ 1 ]
Status Closed [ 6 ] Reopened [ 4 ]
Assignee Monique Szpak [ monique.szpak ] Andrew Hill [ andrew.hill ]

Change by andrew.hill - 28/Jan/09 05:36 PM
Fix Version/s OpenX 2.4.11 [ 10722 ]
Fix Version/s OpenX 2.4.10 [ 10484 ]

Change by andrew.hill - 28/Jan/09 05:36 PM
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]

Change by Nataliya Drabyk - 29/Jan/09 07:47 AM
Status Resolved [ 5 ] Closed [ 6 ]

Change by Matteo Beccati - 17/Feb/09 03:34 PM
Link This issue is referenced by OX-4914 [ OX-4914 ]