History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: OX-4314
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Lukasz Wikierski
Reporter: Arlen Coupland
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
OpenX Ad Server

Entity names do NOT need to be globally unique

Created: 23/Oct/08 12:02 PM   Updated: 08/Jan/09 10:21 AM
Component/s: OXP: Users, Accounts, Permissions & Preferences
Affects Version/s: OpenX 2.7.26-beta
Fix Version/s: OpenX 2.7.27-beta, Milestone 25
Security Level: Public (All users can see these issues)

Time Tracking:
Original Estimate: 8h
Original Estimate - 8h
Remaining Estimate: 2.67h
Time Spent - 5.33h Remaining Estimate - 2.67h
Time Spent: 5.33h
Time Spent - 5.33h Remaining Estimate - 2.67h

File Attachments: 1. File ox-4314.TIF (24 kb)

Issue Links:
Depends
 
Reference
 


 Description  « Hide
Entity names (i.e. Manager, Advertiser and Website Accounts, Campaigns, Banners and Zones) are (sometimes) required to be globally unique - they should not need to be.

Update all of these (if required) so that they have no name restrictions.



 All   Comments   Work Log   Change History   FishEye   Crucible   Builds      Sort Order: Ascending order - Click to sort in descending order
Miguel Correa - 30/Oct/08 12:48 PM - edited
Advertiser with this name already exists" and i don´t have advertisers created yet!

On a different account someone has created an Advertiser with the same name.


Sue Houghton - 03/Nov/08 01:18 PM
Added affects version = 2.7.27-beta for bug triage purposes.

Change by Sue Houghton - 03/Nov/08 01:18 PM
Field Original Value New Value
Affects Version/s  OpenX 2.7.27-beta [ 10487 ]

Change by andrew.hill - 03/Nov/08 01:23 PM
Summary [hosted beta] "Advertiser With This Name Already Exists" error reported when creating first advertiser account Entity names need to be globally unique
Original Estimate 8h [ 28800 ]
Remaining Estimate 8h [ 28800 ]
Assignee Andrew Hill [ andrew.hill ] Lukasz Wikierski [ lukasz.wikierski ]
Fix Version/s  OpenX 2.7.27-beta [ 10487 ]
Fix Version/s Milestone 25 [ 10524 ]
Affects Version/s  OpenX 2.7.27-beta [ 10487 ]
Description http://forum.openx.org/index.php?showtopic=503423067

Reported by forum user 'yasop' ::
In the OpenX Hosted Beta, i try to create my first advertiser and it´s said:
"Advertiser with this name already exists" and i don´t have advertisers created yet! ;-)
Entity names (i.e. Manager, Advertiser and Website Accounts, Campaigns, Banners and Zones) are (sometimes) required to be globally unique - they should not need to be.

Update all of these (if required) so that they have no name restrictions.

Change by andrew.hill - 03/Nov/08 01:23 PM
Status Needs Verification [ 10000 ] Verified [ 10001 ]

Change by andrew.hill - 03/Nov/08 01:23 PM
Status Verified [ 10001 ] Open [ 1 ]

Change by andrew.hill - 03/Nov/08 03:14 PM
Link This issue is depended on by OX-3964 [ OX-3964 ]

Change by Lukasz Wikierski - 04/Nov/08 12:06 PM
Status Open [ 1 ] In Progress [ 3 ]

Lukasz Wikierski - 04/Nov/08 02:28 PM - edited
Checked:
  • agency (manager) is checked for global unique name
  • advertiser was checked for global unique name (FIXED)
  • campaing's name is checked for unique in advertiser's realm
  • banner's name is checked for unique in campaign's realm
  • website was checked for global unique name (FIXED)
  • zone's name is checked for unique in website's realm
  • targeting channel name is checked for unique in website's realm

Fix:

  • advertiser name is checked for unique name in agency's realm
  • website name is checked for unique name in agency's realm

Side effects (same problems like now in 2.6) see attachment ox-4314.TIF:

  • trouble with identifying advertiser/website account on account switcher if names are identical
  • trouble with reading statistics if names of advertisers/websites are identical

Change by Lukasz Wikierski - 04/Nov/08 02:34 PM
Attachment ox-4314.TIF [ 11382 ]

Change by Chris Nutting - 04/Nov/08 02:43 PM
Summary Entity names need to be globally unique Entity names no NOT need to be globally unique

Change by Chris Nutting - 04/Nov/08 02:48 PM
Summary Entity names no NOT need to be globally unique Entity names do NOT need to be globally unique

Lukasz Wikierski - 04/Nov/08 02:51 PM
Time Worked: 3.83h
fixing, testing
mail to Simon
Change by Lukasz Wikierski - 04/Nov/08 02:51 PM
Remaining Estimate 8h [ 28800 ] 4.17h [ 15000 ]
Time Spent 3.83h [ 13800 ]

Change by Lukasz Wikierski - 04/Nov/08 02:52 PM
Status In Progress [ 3 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]

Andriy Petlyovanyy - 07/Nov/08 11:22 AM
Time Worked: 1h
<No comment>
Sue Houghton - 07/Nov/08 04:13 PM - edited
I have come across a few problems while testing this, mainly regarding duplication of entities.

1. Name duplication within a realm:

  • campaign's name is checked for unique in advertiser's realm
  • banner's name is checked for unique in campaign's realm

See OX-4239 for steps showing how it is possible to create campaigns and banners with duplicate names within a realm

2. Incorrect naming of duplicates:

  • zone's name is checked for unique in website's realm
  • targeting channel name is checked for unique in website's realm

See OX-4414


Change by Sue Houghton - 07/Nov/08 04:13 PM
Resolution Fixed [ 1 ]
Status Resolved [ 5 ] Reopened [ 4 ]

Change by Rob Sheppard - 07/Nov/08 04:23 PM
Security Private [ 10064 ] Private & External Partners [ 10065 ]

Change by Rob Sheppard - 07/Nov/08 04:26 PM
Assignee Lukasz Wikierski [ lukasz.wikierski ] Andriy Petlyovanyy [ andriy.petlyovanyy ]

Change by Andriy Petlyovanyy - 10/Nov/08 11:22 AM
Remaining Estimate 4.17h [ 15000 ] 3.17h [ 11400 ]
Time Spent 3.83h [ 13800 ] 4.83h [ 17400 ]

Change by Lukasz Wikierski - 10/Nov/08 11:34 AM
Assignee Andriy Petlyovanyy [ andriy.petlyovanyy ] Lukasz Wikierski [ lukasz.wikierski ]

Change by Lukasz Wikierski - 10/Nov/08 11:41 AM
Status Reopened [ 4 ] In Progress [ 3 ]

Lukasz Wikierski - 10/Nov/08 02:11 PM
Product decision is to allow duplicate name in any element.
Multiple names 'Copy of Something' are allowed as well.

Lukasz Wikierski - 10/Nov/08 02:12 PM
Time Worked: 0.5h
Fixing
Change by Lukasz Wikierski - 10/Nov/08 02:12 PM
Remaining Estimate 3.17h [ 11400 ] 2.67h [ 9600 ]
Time Spent 4.83h [ 17400 ] 5.33h [ 19200 ]

Lukasz Wikierski - 10/Nov/08 02:13 PM - edited
Fixed in 2.7.27-beta-rc6

Fix: Unique checkers was removed from forms


Change by Lukasz Wikierski - 10/Nov/08 02:13 PM
Status In Progress [ 3 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]

Sue Houghton - 11/Nov/08 11:52 AM
closed in 2.7.27-beta-rc6

Change by Sue Houghton - 11/Nov/08 11:52 AM
Status Resolved [ 5 ] Closed [ 6 ]

Change by andrew.hill - 12/Nov/08 04:49 PM
Resolution Fixed [ 1 ]
Status Closed [ 6 ] Reopened [ 4 ]

Change by andrew.hill - 12/Nov/08 04:50 PM
Security Private & External Partners [ 10065 ] Public [ 10060 ]

Change by andrew.hill - 12/Nov/08 04:50 PM
Status Reopened [ 4 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]

Change by Sue Houghton - 12/Nov/08 04:52 PM
Status Resolved [ 5 ] Closed [ 6 ]

Change by Chris Nutting - 08/Jan/09 10:10 AM
Link This issue is duplicated by OX-4186 [ OX-4186 ]

Change by Chris Nutting - 08/Jan/09 10:21 AM
Link This issue is referenced by OX-2813 [ OX-2813 ]