History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: OX-5683
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Chris Nutting
Reporter: Joanna Mazgaj
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
OpenX Ad Server

Cannot uninstall plugin

Created: 12/Aug/09 08:40 AM   Updated: 09/Sep/09 02:37 PM
Component/s: OXP: Plugins
Affects Version/s: OpenX 2.8.2, OpenX 2.8.4
Fix Version/s: OpenX 2.8.2, OpenX 2.8.4, Milestone 34
Security Level: Public (All users can see these issues)

Time Tracking:
Original Estimate: Not Specified
Remaining Estimate: 0h
Time Spent - 1h
Time Spent: 1h
Time Spent - 1h

Issue Links:
Reference
 

Passed QA Version/s: OpenX 2.8.2


 Description  « Hide
in 2.8.2-rc17 and 2.8.3 at the moment plugins cannot be uninstalled:
PLUGIN DEPENDENCY PROBLEM: : unable to determine dependencies for oxMarket - could not locate definition at
PLUGIN DEPENDENCY PROBLEM: : unable to determine dependencies for oxMarket - could not locate definition at
PLUGIN DEPENDENCY PROBLEM: : unable to determine dependencies for oxMarketMaintenance - could not locate definition at
PLUGIN DEPENDENCY PROBLEM: : unable to determine dependencies for oxMarket - could not locate definition at
PLUGIN DEPENDENCY PROBLEM: : unable to determine dependencies for oxMarketMaintenance - could not locate definition at
PLUGIN DEPENDENCY PROBLEM: : unable to determine dependencies for oxMarketDelivery - could not locate definition at
Failed to find package definition file /openx-2.8.2-rc17/plugins/etc/openXMarket.xml
Failed to find package definition file /openx-2.8.2-rc17/plugins/etc/openXMarket.xml

Bug is probably related to latest changes to config file access checks. Plugin entries in config file are not removed



 All   Comments   Work Log   Change History   FishEye   Crucible   Builds      Sort Order: Ascending order - Click to sort in descending order
Matt Plummer - 13/Aug/09 08:24 PM
Let's try to fix as part of 2.8.3.


Matt Plummer - 14/Aug/09 04:18 PM
It was not clear that this was blocking 2.8.2. We need to freeze 2.8.2, so if this is blocking, let's get it fixed.


Chris Nutting - 14/Aug/09 10:31 PM
Fixed in 2.8.3-rc1 and back-ported to 2.8.2-rc19

Chris Nutting - 14/Aug/09 10:51 PM
This change broke the installer

Chris Nutting - 17/Aug/09 10:49 PM
Fixed in 2.8.2-rc19 and 2.8.3-rc1 (hopefully for the last time)

Chris Nutting - 21/Aug/09 12:20 AM
Uninstalling a plugin in the middle of the list removes the entry for all subsequent plugins (as ordered in the config file)

This is because it's using array_diff_assoc(array_keys(), array_keys()) and therefore the array indexes of subsequent entries would be different, they show as differences.

Just swapping to plain array_diff() will fix the issue


Chris Nutting - 21/Aug/09 12:24 AM
Fixed in 2.8.3-rc1 and backported to 2.8.2-rc20

Joanna Mazgaj - 27/Aug/09 02:46 PM
Passes QA in 2.8.2-rc22.

Joanna Mazgaj - 31/Aug/09 12:54 PM
works in 2.8.2-rc22. Closing.