History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: OX-5842
Type: Bug Bug
Status: Needs Verification Needs Verification
Priority: Major Major
Assignee: Unassigned-Adserver
Reporter: Heiko Weber
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
OpenX Ad Server

tracker-invocation.php lookup variables with wrong table-key tracker_id

Created: 08/Dec/09 09:13 AM   Updated: 08/Dec/09 09:36 AM
Component/s: OXP: User Interface
Affects Version/s: OpenX 2.8.2
Fix Version/s: None
Security Level: Public (All users can see these issues)

Time Tracking:
Original Estimate: 0.25h
Original Estimate - 0.25h
Remaining Estimate: 0.25h
Remaining Estimate - 0.25h
Time Spent: Not Specified
Remaining Estimate - 0.25h


 Description  « Hide
www/admin/tracker-invocation.php line # 149

$trackerVariables = Admin_DA::getVariables(array('tracker_id' => $trackerid), true);

is lookup the tracker-variables to set the default invocationcode to javascript when the tracker has variables. Foreign key of variables table is trackerid, not tracker_id, so as a result the invocationcode defaults to js whenever any tracker in openx has variables. So the above line has to be changed in

$trackerVariables = Admin_DA::getVariables(array('trackerid' => $trackerid), true);

The same issue seems to be true at the followinging file / line:

lib/max/Admin_DA.php # 1496 (tracker duplicate will duplicate any variable in the system to new tracker ???)
$aVariables = Admin_DA::getVariables(array('tracker_id' => $trackerId));

Hm, someone should also take a look at the full function _duplicateTracker in Admin_DA.php, tracker_id is used few times, I am not sure which one is correct. Is _duplicateTracker still in use?

foreach ($aVariables as $aVariable) {
    $aVariable['tracker_id'] = $newTrackerId;
    Admin_DA::duplicateVariable($aVariable);
}

Maybe it should read:
$aVariable['trackerid'] = $newTrackerId;

Heiko



 All   Comments   Work Log   Change History   FishEye   Crucible   Builds      Sort Order: Ascending order - Click to sort in descending order
Error communicating with FishEye: java.io.IOException: https://developer.openx.org/fisheye/api/rest/query returned 503 Service Temporarily Unavailable