History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: OXPL-566
Type: Bug Bug
Status: Needs Verification Needs Verification
Priority: Major Major
Assignee: Chris Nutting
Reporter: Georgeana Trofim
Votes: 1
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
OpenX Ad Server Plugins

Internal redirect - wrong logging of requests and impressions

Created: 17/Feb/10 04:44 PM   Updated: 17/Feb/10 04:44 PM
Component/s: OpenX Delivery Log Plugin
Affects Version/s: OpenX Delivery Log Plugin v1.0.9
Fix Version/s: None
Security Level: Public (All users can see these issues)

Time Tracking:
Not Specified


 Description  « Hide
I enabled the internal redirect (so I setup the content of a banner so that it actually calls another zone within my OpenX instance).

When this happens, the requests are logged twice (for the initial banner) and not at all (for the final banner).
The impressions are logged twice (for the final banner) and not at all (for the initial banner).

I made a small fix in the plugin:

  1. svn diff -r48871:HEAD plugins_repo/openXDeliveryLog/plugins/deliveryLog/oxLogImpression/logImpression.delivery.php
    Index: plugins_repo/openXDeliveryLog/plugins/deliveryLog/oxLogImpression/logImpression.delivery.php
    ===================================================================
      • plugins_repo/openXDeliveryLog/plugins/deliveryLog/oxLogImpression/logImpression.delivery.php (revision 48871)
        +++ plugins_repo/openXDeliveryLog/plugins/deliveryLog/oxLogImpression/logImpression.delivery.php (revision 48911)
        @@ -36,8 +36,8 @@
        $aData = $GLOBALS['_MAX']['deliveryData'];
        $aQuery = array(
        'interval_start' => $aData['interval_start'],
  • 'creative_id' => $aData['creative_id'],
  • 'zone_id' => $aData['zone_id']
    + 'creative_id' => $adId,
    + 'zone_id' => $zoneId
    );
    return OX_bucket_updateTable('data_bkt_m', $aQuery);
    }

Same for the requests and clicks.

I was wondering, is this a bug ? I mean, the fix I made fixes my problem, but what was the point of getting the info from $_GLOBALS to begin with ?

Thank you!



 All   Comments   Work Log   Change History   FishEye   Crucible   Builds      Sort Order: Ascending order - Click to sort in descending order
No work has yet been logged on this issue.